https://gitlab.synchro.net/main/sbbs/-/commit/46c603ce3c9eba660f425cc4
Modified Files:
src/sbbs3/prntfile.cpp
Log Message:
Fix NULL pointer deref in random_menu()

When no files with extensions are found, though they matched the glob() pattern, a NULL pointer deref would result (segfault).

This could happen if the only files matching the pattern had no extenions or were directories (not files).

Fix for issue #779

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b656e19ff168e27583a33c26
Modified Files:
src/sbbs3/prntfile.cpp
Log Message:
Report error when menu() can't find a display file and P_NOERROR not used

This issue was introduced in commit d02fc1a2 (3 years ago), where menu() would silenty fail (just return false) if no display file matching the supported menu/display file types/extensions could be found.

Previous to commit d02fc1a2, we would log a NOTICE-level message and display
a "File not found" message to the user (what sbbs_t::printfile() does), but since d02fc1a2, we no longer even call printfile() when the file doesn't
exist, so no error was logged or message displayed to the user.

Of course, when using the P_NOERROR mode flag, silent failure is expected and that's still what happens in that case.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/639781e2ad929914bf27f469
Modified Files:
src/sbbs3/prntfile.cpp
Log Message:
Don't use global menu_dir for calls to menu() with path starting with '.'

For scripts that set the global menu_dir (e.g. via JS bbs.menu_dir), let's
not require that all the files moved from text to text/menu (for example).

Problem reported by Amessyroom when using his custom shell and bullseye.js.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net