Forum: Ricks BBS

comReadBuf() supports an infinite timeout (0)

From Deucе@1:103/705 to GitLab note in main/sbbs on Monday, January 24, 2022 14:37:42

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2223

This seems very dangerous since it will continue block across a disconnection/new connection. Is that the intended use case?
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Monday, January 24, 2022 15:18:58

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2224

Yeah, I mentioned the risks to the requester (Nelgin) and he tested and was okay with the change: upon disconnect, the modem is always sending *something* to the application (SexPOTS), so it always aborts this loop. Still, I made the default timeout non-zero (60 seconds).
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Deucе@1:103/705 to GitLab note in main/sbbs on Monday, January 24, 2022 15:55:48

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2225

While that works fine for his modem usage, I don't understand why he needs more than the 68 years allowed by the timeout value.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Deucе@1:103/705 to GitLab note in main/sbbs on Monday, January 24, 2022 16:02:25

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2226

I'm also not sure why his ask is important enough to potentially break existing consumers and/or add a special-case value.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Deucе@1:103/705 to GitLab note in main/sbbs on Monday, January 24, 2022 16:04:16

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2227

I think passing INT_MAX for infinite timeout would be *much* better than zero. --- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Monday, January 24, 2022 17:06:07

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2228

I did search and could not locate any caller of this function with a timeout parameter value of 0. Seemed like a safe-enough change but using INT_MAX or INT_MIN is fine too.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Nelgin@1:103/705 to Deuc¿ on Tuesday, January 25, 2022 00:42:01

On Mon, 24 Jan 2022 15:55:48 -0800
"Deuc_" <deuc_@VERT> wrote:

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2225

While that works fine for his modem usage, I don't understand why he
needs more than the 68 years allowed by the timeout value.

If someone had told me I cannot have an invite timeout but if you set
it to 0 then it'll be 68 years, I'd have been fine with that.
--
End Of The Line BBS - Plano, TX
telnet endofthelinebbs.com 23
---
� Synchronet � End Of The Line BBS - endofthelinebbs.com
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Who's Online
Recent Visitors
- Bill D
  Thursday, June 26, 2025 18:09:19
  from Silver Springs, MD via Telnet
- Josh Coleman
  Thursday, June 26, 2025 16:52:41
  from Charlotte, Nc via Telnet
- Eddie Wilson
  Thursday, June 26, 2025 14:16:34
  from Galax, VA via HTTP
- Eddie Wilson
  Thursday, June 26, 2025 14:12:24
  from Galax, VA via HTTP
- Robert Gmez
  Thursday, June 26, 2025 08:59:08
  from Ewa Beach, HI via Telnet
- Billy Lawter
  Thursday, June 26, 2025 08:21:49
  from Hyattsville, Md via Telnet
- Jerry Woody
  Thursday, June 26, 2025 06:05:14
  from Cullman, AL via HTTP
- Vern
  Thursday, June 26, 2025 04:03:28
  from Greendale, WI via Telnet

System Info

Sysop:	Rixter
Location:	Madison,NC
Users:	586
Nodes:	10 (0 / 10)
Uptime:	92:26:46
Calls:	2,941
Calls today:	5
Files:	74,275
Messages:	407,232