Pop-Up Thingie

Ricks BBS
  • Home
  • Forum
  • Files
  • News
  • More
    • Synchronet BBS List
  • Register
  • Log in

  1. Forum
  2. FidoNet
  3. SYNC SYSOPS
  • Merge branch 'dd_msg_reader_permission_check_optimizations' into 'mast

    From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tuesday, October 10, 2023 23:08:19
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4319

    You don't need to open a message base to check its configuration. This will definitely slow down this function unnecessarily.

    Instead:
    ```
    canDelete = Boolean(msg_area.sub[this.subBoardCode].settings & SUB_DEL);
    ```

    I'm not clear why you're doing the ```canDelete = canDelete ||` either. Since you've already checked that `CanDelete` is false, that seems unnecessary. And the `== SUB_DEL` is also unnecessary.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tuesday, October 10, 2023 23:09:33
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4320

    Ditto here. Not necessary to open the message base.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tuesday, October 10, 2023 23:10:32
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4321

    Here too. And you've got the other unnecessary bits too.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tuesday, October 10, 2023 23:10:51
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4322

    Same here. :-)
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Wednesday, October 11, 2023 09:01:26
    https://gitlab.synchro.net/main/sbbs/-/commit/22eeb41029934d6f8df7c1ab84b39f39c7b64f31#note_4323

    Thanks. Also, I realized afterward I don't need the "canDelete ||".
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • Who's Online

  • Recent Visitors

    • Bill D
      Thursday, June 26, 2025 18:09:19
      from Silver Springs, MD via Telnet
    • Josh Coleman
      Thursday, June 26, 2025 16:52:41
      from Charlotte, Nc via Telnet
    • Eddie Wilson
      Thursday, June 26, 2025 14:16:34
      from Galax, VA via HTTP
    • Eddie Wilson
      Thursday, June 26, 2025 14:12:24
      from Galax, VA via HTTP
    • Robert Gmez
      Thursday, June 26, 2025 08:59:08
      from Ewa Beach, HI via Telnet
    • Billy Lawter
      Thursday, June 26, 2025 08:21:49
      from Hyattsville, Md via Telnet
    • Jerry Woody
      Thursday, June 26, 2025 06:05:14
      from Cullman, AL via HTTP
    • Vern
      Thursday, June 26, 2025 04:03:28
      from Greendale, WI via Telnet
  • System Info

    Sysop: Rixter
    Location: Madison,NC
    Users: 586
    Nodes: 10 (0 / 10)
    Uptime: 92:26:11
    Calls: 2,941
    Calls today: 5
    Files: 74,275
    Messages: 407,232

© Ricks BBS, 2025